Fix/vanish #238
Open
Fix/vanish #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the vanish mode functionality and annotation sizing system to track line sizes per subtask rather than per annotation. It introduces a new keybind for toggling vanish mode across all subtasks, removes the deprecated default_annotation_size configuration, and fixes positioning issues with the toolbox collapse button.
Changes:
- Moved annotation line size tracking from individual annotations to per-subtask state
- Added
annotation_vanish_all_keybindconfiguration option with shift+v default - Removed
line_sizeproperty from annotation objects and deprecateddefault_annotation_sizeconfig - Fixed toolbox collapse button positioning to use absolute instead of fixed positioning
Reviewed changes
Copilot reviewed 19 out of 22 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/annotation.ts | Removed line_size parameter from ULabelAnnotation class |
| src/configuration.ts | Removed deprecated default_annotation_size, added annotation_vanish_all_keybind, changed default initial_line_size to 5 |
| src/index.js | Removed line_size initialization from annotations, moved to subtask state; updated get_scaled_line_size to use subtask line size |
| src/listeners.ts | Added keybind handlers for annotation resizing that call AnnotationResizeItem methods |
| src/subtask.ts | Added is_vanished and line_size properties to subtask state |
| src/toolbox.ts | Refactored AnnotationResizeItem to use static methods and track line size per subtask; removed cookie-based size storage; fixed collapse button positioning |
| src/toolbox_items/keybinds.ts | Added new "Toggle Vanish All" keybind entry and updated "Toggle Vanish" description |
| tests/annotation.test.js | Removed assertion checking line_size on annotation object |
| tests/e2e/keybind-functionality.spec.js | Updated vanish keybind test to check subtask state instead of annotation line_size |
| tests/testing-utils/init_utils.js | Added return of ulabel instance from wait_for_ulabel_init |
| tests/testing-utils/subtask_utils.js | Added get_current_subtask utility function |
| package.json | Bumped version to 0.22.1, added baseline-browser-mapping dependency |
| api_spec.md | Removed line_size from annotation spec, removed default_annotation_size documentation, updated initial_line_size default to 5 |
| CHANGELOG.md | Added 0.22.1 release notes with future date (Jan 13th, 2026) |
| demo files | Removed line_size properties from example annotations |
| .github/tasks.md | Updated tasks list |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Vanish Mode
Description
annotation_vanish_all_keybindline_sizeproperty from the annotation object. Use the subtaskline_sizeinstead.default_annotation_sizeargument in the configuration object. Use theinitial_line_sizeargument instead. See api_spec.md for details.Implements some functionality I initially implemented as part of #153, however the rest of that PR is pretty obsolete. Closes #153.
PR Checklist
package.jsonhas been bumped since last releasepackage.jsonandsrc/version.jsnpm installandnpm run buildAFTER bumping the version numberapi_spec.md)changelog.mdBreaking API Changes
default_annotation_sizeargument in the configuration object. Use theinitial_line_sizeargument instead. See api_spec.md for details.line_sizeproperty from annotation objects.subtask.state.line_sizedetermined the size of drawn annotations within a subtask.